autofixture Issue Tracker Rss Feed

Commented Feature: Auto-mocking extensions should auto-fill properties [4245]

mfreidge — Tue, 18 Jun 2013 12:33:43 GMT

See the discussion in the comments here http://blog.ploeh.dk/2010/08/19/AutoFixtureAsAnAutomockingContainer.aspx
Comments: @vinneyk, Do not overuse interfaces - see http://stackoverflow.com/questions/90851/is-creating-interfacesfor-almost-every-class-justified-or-are-interfaces-overus From http://martinfowler.com/bliki/InterfaceImplementationPair.html Using interfaces when you aren't going to have multiple implementations is extra effort to keep everything in sync.Furthermore it hides the cases where you actually do provide multiple implementations.

Commented Feature: Auto-mocking extensions should auto-fill properties [4245]

ploeh — Mon, 08 Apr 2013 05:59:11 GMT

See the discussion in the comments here http://blog.ploeh.dk/2010/08/19/AutoFixtureAsAnAutomockingContainer.aspx
Comments: FWIW, I've posted a couple of blog posts describing how to achieve this effect: http://blog.ploeh.dk/2013/04/08/how-to-automatically-populate-properties-with-automoq/

Commented Feature: Auto-mocking extensions should auto-fill properties [4245]

vinneyk — Wed, 03 Apr 2013 14:55:44 GMT

See the discussion in the comments here http://blog.ploeh.dk/2010/08/19/AutoFixtureAsAnAutomockingContainer.aspx
Comments: My group has adopted the practice of exposing only interfaces as return objects and parameters for our business-layer API. This is a fairly new change so it's possible that we'll eventually come to understand why Mark considers interface properties to be a code smell. However, for the time being, this has allotted the following benefits for our MVC application: (1) ViewModel objects can implement parameter interfaces which prevents the need to convert from the vm to the service model and (2) views models tend to be composed of one or more interfaces rather than deriving, exposing, or duplicating the properties of the service model. So far, the two areas where this practice has been difficult are the lack of support for interface parameters in the MVC WebAPI actions and this inability to create anonymous mocks for testing. If this feature is indeed not desired by the AutoFixture team, perhaps someone from the team could give some further clues as to how to extend this functionality ourselves. Thanks for the awesome AutoFixture libraries!

Closed Issue: Regular Expression support doesn't like digits [4254]

baxevanis — Sun, 27 Jan 2013 17:04:56 GMT

Attempt to resolve a RegularExpressionRequest for a set of digits, e.g. with this pattern:

@"\d{8}"

That pattern means 'exactly 8 digits', and a string like this satisfies the pattern: "12345678"

However, an attempt to resolve a new RegularExpressionRequest(@"\d{8}") returns a NoSpecimen result.
Comments: Resolved in version 2.16.2.0 (changeset [a365f031aa](https://github.com/AutoFixture/AutoFixture/commit/a365f031aa4089cc5304c77b77a40203c06f1127))

Closed Issue: InvalidCastException on nullable ints with RangeAttribute [4258]

baxevanis — Sat, 10 Nov 2012 18:22:56 GMT

I have a type containing a property of type int? with a RangeAttribute. When I use AutoFixture to generate a new instance of this type, the following exception is thrown:

System.InvalidCastException : Invalid cast from 'System.Int32' to 'System.Nullable`1[[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]]'.
at System.Convert.DefaultToType(IConvertible value, Type targetType, IFormatProvider provider) at System.Int32.System.IConvertible.ToType(Type type, IFormatProvider provider) at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider) at Ploeh.AutoFixture.DataAnnotations.RangeAttributeRelay.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.Postprocessor`1.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.RecursionGuard.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.AutoPropertiesCommand`1.Execute(T specimen, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.Postprocessor`1.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.RecursionGuard.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.Postprocessor`1.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.RecursionGuard.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.SpecimenFactory.CreateAnonymous(ISpecimenContext context, T seed) at Ploeh.AutoFixture.SpecimenFactory.CreateAnonymous(ISpecimenContext context) at ECG.Test.NET.UnitTestBase.A() in c:\TeamCity\buildAgent\work\e074cba96cce5f8e\Test.NET\UnitTestBase.cs: line 28 at DealerHub.Tests.UnitTests.Api.Controllers.CarControllerTest.CannotSaveCarWithoutFirstRegistrationDate() in CarControllerTest.cs: line 363

Comments: Resolved in version 2.13.5 (changeset 8718a12 on github)

Commented Issue: InvalidCastException on nullable ints with RangeAttribute [4258]

ThomasArdal — Thu, 08 Nov 2012 19:10:39 GMT

I have a type containing a property of type int? with a RangeAttribute. When I use AutoFixture to generate a new instance of this type, the following exception is thrown:

System.InvalidCastException : Invalid cast from 'System.Int32' to 'System.Nullable`1[[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]]'.
at System.Convert.DefaultToType(IConvertible value, Type targetType, IFormatProvider provider) at System.Int32.System.IConvertible.ToType(Type type, IFormatProvider provider) at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider) at Ploeh.AutoFixture.DataAnnotations.RangeAttributeRelay.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.Postprocessor`1.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.RecursionGuard.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.AutoPropertiesCommand`1.Execute(T specimen, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.Postprocessor`1.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.RecursionGuard.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.Postprocessor`1.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.RecursionGuard.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.SpecimenFactory.CreateAnonymous(ISpecimenContext context, T seed) at Ploeh.AutoFixture.SpecimenFactory.CreateAnonymous(ISpecimenContext context) at ECG.Test.NET.UnitTestBase.A() in c:\TeamCity\buildAgent\work\e074cba96cce5f8e\Test.NET\UnitTestBase.cs: line 28 at DealerHub.Tests.UnitTests.Api.Controllers.CarControllerTest.CannotSaveCarWithoutFirstRegistrationDate() in CarControllerTest.cs: line 363

Comments: Sorry. Bug created here: https://github.com/AutoFixture/AutoFixture/issues/24

Commented Issue: InvalidCastException on nullable ints with RangeAttribute [4258]

ploeh — Thu, 08 Nov 2012 15:34:29 GMT

I have a type containing a property of type int? with a RangeAttribute. When I use AutoFixture to generate a new instance of this type, the following exception is thrown:

System.InvalidCastException : Invalid cast from 'System.Int32' to 'System.Nullable`1[[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]]'.
at System.Convert.DefaultToType(IConvertible value, Type targetType, IFormatProvider provider) at System.Int32.System.IConvertible.ToType(Type type, IFormatProvider provider) at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider) at Ploeh.AutoFixture.DataAnnotations.RangeAttributeRelay.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.Postprocessor`1.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.RecursionGuard.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.AutoPropertiesCommand`1.Execute(T specimen, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.Postprocessor`1.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.RecursionGuard.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.Postprocessor`1.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.<>c__DisplayClass6.<Create>b__1(ISpecimenBuilder b) at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.<DefaultIfEmptyIterator>d__a5`1.MoveNext() at System.Linq.Enumerable.FirstOrDefault(IEnumerable`1 source) at Ploeh.AutoFixture.Kernel.RecursionGuard.Create(Object request, ISpecimenContext context) at Ploeh.AutoFixture.SpecimenFactory.CreateAnonymous(ISpecimenContext context, T seed) at Ploeh.AutoFixture.SpecimenFactory.CreateAnonymous(ISpecimenContext context) at ECG.Test.NET.UnitTestBase.A() in c:\TeamCity\buildAgent\work\e074cba96cce5f8e\Test.NET\UnitTestBase.cs: line 28 at DealerHub.Tests.UnitTests.Api.Controllers.CarControllerTest.CannotSaveCarWithoutFirstRegistrationDate() in CarControllerTest.cs: line 363

Comments: AutoFixture has moved to github. Can I kindly ask you to report the issue there? https://github.com/AutoFixture/AutoFixture/issues?state=open Thank you

Created Issue: InvalidCastException on nullable ints with RangeAttribute [4258]

ThomasArdal — Thu, 08 Nov 2012 13:43:43 GMT

Commented Issue: xUnit.net versioning [4241]

EdvL — Wed, 03 Oct 2012 20:02:25 GMT

I noticed some strange behavior when getting AutoFixture with xUnit data theories from NuGet.

AutoFixture references 'xunit.extensions, Version=1.6.1.1521, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c' assembly. However, on NuGet the available xUnit.net packages start from version 1.7.0.1540. So NuGet fetched this version instead of the 1.6.1.1521.

At runtime, I get a FileLoadException:

System.IO.FileLoadException was unhandled
Message=Could not load file or assembly 'xunit.extensions, Version=1.6.1.1521, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
Source=mscorlib
FileName=xunit.extensions, Version=1.6.1.1521, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c

I think that this may discourage new users from trying AutoFixture because they will have to find the specific xUnit.net version themselves. Shall we upgrade to xUnit 1.7 or 1.8? (personally I would choose 1.8).

Comments: quick fix: executing "Add-BindingRedirect" in the package manager console for the test project which is using Autofixture fixes this exception

Commented Issue: xUnit.net versioning [4241]

nikmd23 — Tue, 02 Oct 2012 22:58:00 GMT

I noticed some strange behavior when getting AutoFixture with xUnit data theories from NuGet.

AutoFixture references 'xunit.extensions, Version=1.6.1.1521, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c' assembly. However, on NuGet the available xUnit.net packages start from version 1.7.0.1540. So NuGet fetched this version instead of the 1.6.1.1521.

At runtime, I get a FileLoadException:

System.IO.FileLoadException was unhandled
Message=Could not load file or assembly 'xunit.extensions, Version=1.6.1.1521, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
Source=mscorlib
FileName=xunit.extensions, Version=1.6.1.1521, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c

I think that this may discourage new users from trying AutoFixture because they will have to find the specific xUnit.net version themselves. Shall we upgrade to xUnit 1.7 or 1.8? (personally I would choose 1.8).

Comments: I have this problem with the R# test runner as well. :( Hope to see a fix for this soon.

Closed Issue: RangeAttribute on decimal property or field [4257]

baxevanis — Tue, 03 Jul 2012 06:18:41 GMT

An exception is thrown when a decimal property or field is decorated with the [Range] attribute.
Comments: Resolved in version 2.11.3 (changeset 2a1957988210)

Created Issue: RangeAttribute on decimal property or field [4257]

baxevanis — Sun, 01 Jul 2012 09:48:27 GMT

An exception is thrown when a decimal property or field is decorated with the [Range] attribute.

Commented Task: Less scary-sounding API [4253]

baxevanis — Sun, 24 Jun 2012 12:06:24 GMT

Consider renaming scary-sounding method names like "CreateAnonymous" to simply "Create".
Comments: Surely a good one, yes!

Commented Task: Less scary-sounding API [4253]

ploeh — Sun, 24 Jun 2012 08:01:00 GMT

Consider renaming scary-sounding method names like "CreateAnonymous" to simply "Create".
Comments: Agreed. Renaming the method changes the semantics. However, one could argue that simply the fact that a unit test is using AutoFixture creates a context where it's given what "Create" means. In any case, I've heard plenty of feedback stating that "CreateAnonymous" is a barrier to adoption simply because it sounds unfamiliar. If that's true, changing the name would be a good trade-off.

Closed Issue: fixture.CreateAnonymous(); - Does not work! [4256]

ploeh — Sun, 24 Jun 2012 07:56:01 GMT

Some of my classes accept a System.IO.TextReader dependency. This is an abstract class, so I thought it would be fine for loosely coupled code (and indeed it works and can be mocked [I use Moq]). The following code errors (and so does any CreateAnonymous usages on a type that expects a TextReader as a parameter):

var fixture = new Fixture().Customize(new AutoMoqCustomization());
fixture.CreateAnonymous<TextReader>();

Ploeh.AutoFixture.ObjectCreationException : AutoFixture was unable to create an instance of type Ploeh.AutoFixture.Kernel.SeededRequest because the traversed object graph contains a circular reference. Information about the circular path follows below. This is the correct behavior when a Fixture is equipped with a ThrowingRecursionBehavior, which is the default. This ensures that you are being made aware of circular references in your code. Your first reaction should be to redesign your API in order to get rid of all circular references. However, if this is not possible (most likely because parts or all of the API is delivered by a third party), you can replace this default behavior with a different behavior: on the Fixture instance, remove the ThrowingRecursionBehavior from Fixture.Behaviors, and instead add an instance of OmitOnRecursionBehavior.
Path:
System.IO.TextReader reader -->
System.IO.TextReader -->
System.IO.TextReader

So... I do as follows:

var fixture = new Fixture().Customize(new AutoMoqCustomization());
fixture.Behaviors.Clear();
fixture.Behaviors.Add(new OmitOnRecursionBehavior());
fixture.Behaviors.Add(new TracingBehavior());
fixture.CreateAnonymous<TextReader>();

And this results in:

Requested: Ploeh.AutoFixture.Kernel.SeededRequest
Requested: System.IO.TextReader
Requested: System.IO.TextReader reader
Requested: Ploeh.AutoFixture.Kernel.SeededRequest
Requested: System.IO.TextReader
Created: Ploeh.AutoFixture.Kernel.OmitSpecimen
Created: Ploeh.AutoFixture.Kernel.OmitSpecimen
Created: Ploeh.AutoFixture.Kernel.OmitSpecimen

System.ArgumentException : Object of type 'Ploeh.AutoFixture.Kernel.OmitSpecimen' cannot be converted to type 'System.IO.TextReader'.
Comments: Resolved in AutoFixture 2.11.2.

Commented Issue: fixture.CreateAnonymous(); - Does not work! [4256]

ploeh — Sun, 24 Jun 2012 07:55:38 GMT

Commented Task: Less scary-sounding API [4253]

baxevanis — Sat, 23 Jun 2012 21:19:00 GMT

Consider renaming scary-sounding method names like "CreateAnonymous" to simply "Create".
Comments: From a test reader's perspective, renaming to "Create" might change the semantics of the relationship with the Anonymous Variables article (http://blogs.msdn.com/b/ploeh/archive/2008/11/17/anonymous-variables.aspx). (Or no?)

Edited Issue: fixture.CreateAnonymous(); - Does not work! [4256]

ploeh — Sat, 23 Jun 2012 08:22:28 GMT

Commented Issue: fixture.CreateAnonymous(); - Does not work! [4256]

ploeh — Sat, 23 Jun 2012 08:22:12 GMT

Edited Issue: fixture.CreateAnonymous(); - Does not work! [4256]

ploeh — Fri, 22 Jun 2012 18:41:47 GMT